Improve default behavior of string search (NUL = new line)#6573
Open
Rot127 wants to merge 2 commits into
Open
Conversation
Rot127
requested review from
b1llow,
kazarmy,
notxvilka,
ret2libc,
thestr4ng3r and
wargio
as code owners
June 28, 2026 13:42
That is the most intuitive option for binary searches. The behavior can still be changed, as seen in the added example.
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
notxvilka
approved these changes
Jun 29, 2026
wargio
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
This adds some string search improvements which could be interpreted as a bug.
Because the default configuration is not sensible.
The string search (
/z) use the default line endings which are not NUL bytes.That is really weird in binaries, because a regex like
.+would match a NUL byte.People could change the behavior by prefixing a regex with
(*NUL)but who does this?This PR changes the default behavior to interpret NUL as line ending.
Additionally, it allows now the d (dot all) and m (multiline) flag in combination with
r.Test plan
Added
Closing issues
...